Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/table): error if outlets are assigned too early #28551

Merged
merged 1 commit into from
Feb 8, 2024
Merged

fix(cdk/table): error if outlets are assigned too early #28551

merged 1 commit into from
Feb 8, 2024

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 7, 2024

Fixes that the table was throwing an error if all outlets are assigned before ngAfterContentInit.

Fixes #28538.

@crisbeto
fix(cdk/table): error if outlets are assigned too early
2dd3212 
Fixes that the table was throwing an error if all outlets are assigned before `ngAfterContentInit`.

Fixes angular#28538.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 7, 2024
@crisbeto crisbeto mentioned this pull request Feb 7, 2024
Closed
1 task
@crisbeto crisbeto self-assigned this Feb 8, 2024
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Feb 8, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 8, 2024
@crisbeto crisbeto merged commit add3cd4 into angular:main Feb 8, 2024
29 checks passed
crisbeto added a commit that referenced this pull request Feb 8, 2024
@crisbeto
fix(cdk/table): error if outlets are assigned too early (#28551)
f797014 
Fixes that the table was throwing an error if all outlets are assigned before `ngAfterContentInit`.

Fixes #28538.

(cherry picked from commit add3cd4)
crisbeto added a commit that referenced this pull request Feb 8, 2024
@crisbeto
fix(cdk/table): error if outlets are assigned too early (#28551)
2f7aaaa 
Fixes that the table was throwing an error if all outlets are assigned before `ngAfterContentInit`.

Fixes #28538.

(cherry picked from commit add3cd4)
@crisbeto crisbeto mentioned this pull request Feb 22, 2024
Closed
1 task
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(CdkTable): render QueryList timing issue in >= 17.1.0
2 participants
@crisbeto @andrewseguin